Fixes #37469 - Support Zeitwerk loader #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#77 should also provide EL 9 RPMs and use a RHEL buildroot. |
ofedoren
force-pushed
the
feat-37469-support-zeitwerk
branch
from
4be7cb3
to
fdf284a
Compare
ofedoren
force-pushed
the
feat-37469-support-zeitwerk
branch
from
fdf284a
to
a44a0cf
Compare
I think this may hit the bug where the buildroot for a PR isn't updated if you rebase it. Doesn't matter, it still produces the SRPM for me and I rebuild it in COPR anyway. |
ofedoren
force-pushed
the
feat-37469-support-zeitwerk
branch
2 times, most recently
from
4a4a1ae
to
8d83846
Compare
ofedoren
force-pushed
the
feat-37469-support-zeitwerk
branch
from
8d83846
to
191d688
Compare
|
Ready to merge after theforeman/foreman#10131 is merged, dropped the commit for testing with Foreman PR, the latest run was green: |
ekohl
approved these changes
Sep 10, 2024
|
Thank you @ofedoren ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP